Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Update pd client to apply a new api path #56255

Closed
wants to merge 3 commits into from
Closed

*: Update pd client to apply a new api path #56255

wants to merge 3 commits into from

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Sep 24, 2024

What problem does this PR solve?

Issue Number: close #56254

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@okJiang
bump version
8a9d2bf 
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from okjiang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1452%. Comparing base (7b6209d) to head (f696e89).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56255        +/-   ##
================================================
+ Coverage   73.4312%   75.1452%   +1.7139%     
================================================
  Files          1607       1619        +12     
  Lines        445889     447806      +1917     
================================================
+ Hits         327422     336505      +9083     
+ Misses        98411      90802      -7609     
- Partials      20056      20499       +443
Flag Coverage Δ
integration 49.1038% <ø> (?)
unit 72.4518% <ø> (-0.0578%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4122% <ø> (+4.4080%) ⬆️

@lance6716
Copy link
Contributor

/hold

After this PR, lightning can't use a different version with cluster? If so please check with PM

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@okJiang
Copy link
Member Author

okJiang commented Sep 24, 2024

@lance6716 This api seems not be used by lightning. You can check it.

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@okJiang
Copy link
Member Author

okJiang commented Sep 24, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Sep 24, 2024

/cc @rleungx @HuSharp

@okJiang
Copy link
Member Author

okJiang commented Sep 25, 2024

/retest

@HuSharp
Copy link
Contributor

HuSharp commented Sep 25, 2024

/retest

Have you updated bazel?

@okJiang
Copy link
Member Author

okJiang commented Sep 25, 2024

/retest

@HuSharp
Copy link
Contributor

HuSharp commented Sep 25, 2024 •
edited
Loading

/retest

Have you updated bazel?

You need to run make bazel_prepare and update cache in 10.2.12.124 :) @okJiang

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@okJiang
Copy link
Member Author

okJiang commented Sep 26, 2024

/retest

Have you updated bazel?

You need to run make bazel_prepare and update cache in 10.2.12.124 :) @okJiang

Done~

@okJiang
Copy link
Member Author

okJiang commented Sep 26, 2024

#56292 has updated pd-client to a newer version. So we can close this pr and issue.

@okJiang okJiang closed this Sep 26, 2024
@okJiang okJiang deleted the update-pd-client branch September 26, 2024 08:37
@okJiang okJiang mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp Awaiting requested review from HuSharp

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pd client to apply a new api path
3 participants
@okJiang @lance6716 @HuSharp